Contrib.social

Module is not PHP 7.4 compatible anymore

Open on Drupal.org →
Created on 26 January 2023, almost 2 years ago
Updated 27 January 2023, almost 2 years ago

Problem/Motivation

In #3299349: Automated Drupal 10 compatibility fixes → there have been changes introduced that broke the PHP 7.4 compatibility, because of a trailing comma in the constructor of src/Plugin/Field/FieldFormatter/Base.php

  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, ConfigFactoryInterface $configFactory,) {

This is only allowed from PHP 8.0 onwards.

Steps to reproduce

Proposed resolution

Even though PHP 7.4 is EOL, there are still a lot of installations running it.

The module should declare PHP 8 as a requirement or remove the trailing comma agan.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany szeidler Berlin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024