Contrib.social

Compatibility with messages in details (permanent messages)

Open on Drupal.org →
Created on 26 January 2023, about 2 years ago
Updated 23 April 2023, almost 2 years ago

Problem/Motivation

When a message is rendered in a permanent, informative way, it cannot be rendered by toastify correctly, but is also removed from its original location. This results in the user not able to read the message at all.

Steps to reproduce

  • Install and enable Webform, Webform UI
  • Go to Admin > Structure > Webform > Webforms, select an example webform or Contact, go to Build
  • Move to Settings: some warning messages are visible in some details blocks

  • Install and enable Toastify
  • Move to Build, then again to Settings
  • Toastify shows "Object, Object" and is unable to render the proper messages (even if it could, the fact they are not rendered into the proper details block strips out all the context needed to understand the message

  • The messages in the details are not rendered anymore

Proposed resolution

Toastify should be able to omit messages in details or in other page locations.
This might be tricky to do so without targeting the main messages block (eg Highlighted by default).

I was initially thinking about adding some kind of selector for the "main" messages block in Highlighted, but this is subject to change depending on the theme. Also I'm not sure this wouldn't break ajax messages.

What do you think ?

🐛 Bug report
Status

Fixed

Version

1.0

Component

User interface

Created by

🇫🇷France superbiche Nantes

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024