Remove unnecessary variables from core/modules/system/tests/src/Functional/Menu/BreadcrumbTest.php

PHPStan baseline needs updating.

We should also look at the history of this file to find out why it is like this - have we lost test coverage somewhere or is this a genuine mistake?

Hey @longwave thanks for the review!

PHPStan baseline needs updating.

Whooops... I've create an MR instead with the patch and the baseline updated.

We should also look at the history of this file to find out why it is like this - have we lost test coverage somewhere or is this a genuine mistake?

That's a good idea, I was taking a look at the history of this file, and the variables were first introduced on commit 480497f1, along with some breadcrumb tests, more specific on these lines: 271-285.

After a while the issue: #2070651: Introduce a path-based breadcrumb builder, remove the one that's based on {menu_links}. → removed some of the tests and made the variables unused, being more specific the patch from #58 → removed the tests and the issue was commited on 00c06fcfedb. You can check the final file more clear and what happened on the blob file, lines 216-268.

It seems to me a genuine mistake, but what do you think?

Moving back to NR

Hi @murilohp, Reviewed MR!3294. It was successfully applied and removed unnecessary variables inside the testBreadCrumbs function.Need RTBC+1

Thank you @murilohp. I agree with your assessment that this block of code was missed when the tests were refactored over in #2070651: Introduce a path-based breadcrumb builder, remove the one that's based on {menu_links}. → and it is safe to remove.

@Rinku Jacob 13 thank you for your comment, however GitLab and DrupalCI wil tell us if a patch applies or not - there is no need to upload screenshots of patches.

Committed 4805699 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.