- Issue created by @lauriii
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
AFAICT https://github.com/ckeditor/ckeditor5/issues/5154 would fix this, which would make it related to 🐛 EditorFileReference should compute a px if a % is specified, even though % is not allowed in HTML5 Needs work .
- Assigned to lauriii
- Status changed to Postponed: needs info
almost 2 years ago 3:38pm 26 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
On second thought, this would actually mean that this is an upstream bug: it looks like CKEditor 5 blindly assumes that the
<figure>
wrapping an<img>
has the same width as the figure?!Assigning to @lauriii for confirmation.
- Status changed to Active
almost 2 years ago 10:50am 30 January 2023 - 🇫🇮Finland lauriii Finland
I was trying to point out a bug that is happening when the content is being processed into
\Drupal\filter\Render\FilteredMarkup
. As part of that process,<figure>
element is created in\Drupal\filter\Plugin\Filter\FilterCaption::process
based offdata-caption
. It sounds like there are two separate bugs, one within CKEditor 5, and one that is related to\Drupal\filter\Plugin\Filter\FilterCaption
. This looks like a duplicate of 🐛 CKEditor 5 resizes images with % width instead of px width (the CKEditor 4 default): breaks image captions *and* is a regression Fixed .
- Issue was unassigned.
- Status changed to Closed: duplicate
over 1 year ago 1:22pm 5 July 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Well, 🐛 CKEditor 5 resizes images with % width instead of px width (the CKEditor 4 default): breaks image captions *and* is a regression Fixed will fix it for all images as soon as they are resized again.
🐛 EditorFileReference should compute a px if a % is specified, even though % is not allowed in HTML5 Needs work would still be appropriate hardening, but I agree there's nothing left to do here (besides, this really does belong in the
filter.module
component, even though it's typically caused by CKEditor 5).Agreed with the course of action that @dabley proposed though, and crediting him for it! 😊🙏 One less issue!