Drupal Coding Standards Issues | phpcs

$ phpcs --standard=Drupal simple_wysiwyg FILE: C:\Users\Admin\Desktop\task\simple_wysiwyg\css\simple-wysiwyg.css -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\task\simple_wysiwyg\js\simple-wysiwyg.js -------------------------------------------------------------------------------- FOUND 12 ERRORS AFFECTING 11 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 56 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but | | found "true" 65 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 66 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 73 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but | | found "true" 82 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found 84 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but | | found "true" 141 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but | | found "true" 160 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but | | found "false" 160 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but | | found "null" 171 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but | | found "false" 174 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but | | found "true" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...\simple_wysiwyg\src\Plugin\Field\FieldFormatter\SimpleWysiwygFormatter.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...p\task\simple_wysiwyg\src\Plugin\Field\FieldWidget\SimpleWysiwygWidget.php -------------------------------------------------------------------------------- FOUND 6 ERRORS AND 2 WARNINGS AFFECTING 8 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n" 26 | ERROR | [ ] The array declaration extends to column 88 (the limit is | | 80). The array content should be split up over multiple | | lines 27 | ERROR | [ ] The array declaration extends to column 86 (the limit is | | 80). The array content should be split up over multiple | | lines 28 | ERROR | [ ] The array declaration extends to column 93 (the limit is | | 80). The array content should be split up over multiple | | lines 29 | ERROR | [ ] The array declaration extends to column 96 (the limit is | | 80). The array content should be split up over multiple | | lines 54 | WARNING | [ ] Only string literals should be passed to t() where | | possible 100 | WARNING | [ ] Only string literals should be passed to t() where | | possible 157 | ERROR | [x] Expected 1 space after IF keyword; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 475ms; Memory: 10MB

Comments & Activities

Issue created by @Jay Jangid
@jay-jangid opened merge request.
Comment almost 2 years ago →
🇮🇳India Jay Jangid
Created MR , please review.

Thank you.
First commit to issue fork.
Comment about 1 year ago →
🇦🇲Armenia murz Yerevan, Armenia
Thank you for the patch! But phpcs rules should not be applied to js files. Look, for example, into the core/misc/ajax.js file - booleans are not capitalized, etc.

And removing "t" function like this:

- $buttonsOptions[$id] = $this->t($settings['title']); + $buttonsOptions[$id] = $this->($settings['title']);

will lead to errors!

So, please be careful and check your automated patches!

I fixed these by myself.
Comment about 1 year ago →
System Message

Murz → committed 39017495 on 1.0.x authored by Jay Jangid →
Issue #3336389: Drupal Coding Standards Issues | phpcs
Comment about 1 year ago →
🇦🇲Armenia murz Yerevan, Armenia
Status changed to Fixed about 1 year ago12:56pm 7 October 2023
Comment about 1 year ago →
🇦🇲Armenia murz Yerevan, Armenia

Drupal Coding Standards Issues | phpcs

Problem/Motivation

Proposed resolution

Comments & Activities