Pagination settings in View are not used

Interesting side note. If you display the results summary in the header, it shows "Displaying 1 - 10 of 817" So the counter knows correctly how many it should be showing.

Thanks for the steps to reproduce.

As we are programatically creating the views, we likely are avoiding the additional complexity of adding the pagers.

I suspect that this may be an opportunity to look at the code that builds up the views. Adding a pager should be an additional call. I haven't spent a lot of time looking at view "Builder" code. I hope the pieces that would make this easy are there.

Added pagination support + test coverage.

My concern is that all of a sudden pagination is kicking in and existing sites are seeing all results. Probably we need to add an update hook to the views provided by this module and check if the pagination is unchanged, and if so, set to unlimited to maintain the status quo. When someone does a composer update to this module, they are unlikely to otherwise notice immediately.

Alternatively we could make it clear in the release notes, but not confident how well that will get noticed...

Okay tests passing now

Okay going to go for release notes idea since its a bug not a feature (even if there is some small risk people may be using it as such, they'll see the pagination since this does not work with areas that don't support pagination like ✨ Make this module work with Views Selection from Core Active yet).

Automatically closed - issue fixed for 2 weeks with no activity.