Fix all file permissions

The last submitted patch, 2: 3336291-file-permissions.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

"Build Successful" means there are no fails. This module has no tests to fail. But as you can see Drupal CI ran and did a coding standards check on the code as a side effect.

It is a long-standing testbot bug that "Build Successful" improperly moves the issue status to "Needs work" when is should (and in fact used to) show as Green/Pass without changing the issue status.

Eventually we should probably add tests.

If it becomes a problem we can always add a simple file that does some generic assertion that the form exists or something.

Eventually we should probably add tests.

Yes, that's the idea. This desperately needs tests, but there's a lot of groundwork to do first like getting it to actually install on D9/D10 and having Drupal CI configured (that's done now I see) so that new tests can be tested ...

I will contribute some tests for the Rules integration when I get to that point.

For future reference, please pay attention to commit credits when you commit a patch. The git commit command shown at the bottom of this page is the suggested way to grant credit.
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →

Accidentally changed status ... restoring ...

Automatically closed - issue fixed for 2 weeks with no activity.