- Issue created by @tedbow
- @tedbow opened merge request.
- 🇺🇸United States tedbow Ithaca, NY, USA
Created 📌 Throw an exception if stopPropagation() called for `PreOperationStageEvent` and no error has been added Fixed because I realized you could easily mess up the validation if you didn't know what you were doing
- Assigned to kunal.sachdev
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:02am 25 January 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
almost 2 years ago 7:38am 26 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
4 remarks on the MR — but I'm so glad the API docs are getting improved! 😄👍
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 8:52am 27 January 2023 - Status changed to Needs work
almost 2 years ago 1:04pm 27 January 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Getting there … but still a few remarks 😇
- Assigned to kunal.sachdev
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 2:49pm 27 January 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
almost 2 years ago 1:05pm 8 February 2023 - Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 1:52pm 8 February 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
almost 2 years ago 8:54pm 8 February 2023 - Assigned to wim leers
- Status changed to Needs review
almost 2 years ago 7:38am 9 February 2023 - Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 8:59am 9 February 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Ready to land!
@tedbow: let's land this, so we can finally do 📌 Define the Package Manager API (package_manager.api.php is outdated) Fixed , which this blocks. 🤞
- Status changed to Needs work
almost 2 years ago 2:22pm 9 February 2023 - 🇺🇸United States phenaproxima Massachusetts
Sorry to kick this back, but there are a few things I'd like to see changed here for clarity's sake. (If you want, I can do the work - just assign it to me.)
- Status changed to Needs review
almost 2 years ago 7:08am 10 February 2023 - Assigned to phenaproxima
- Status changed to RTBC
almost 2 years ago 11:56am 13 February 2023 - 🇺🇸United States phenaproxima Massachusetts
Looks good to me!
Made a couple of small fixes-on-commit, will merge when tests pass.
-
phenaproxima →
committed 58237485 on 8.x-2.x authored by
tedbow →
Issue #3336243 by kunal.sachdev, tedbow, phenaproxima, Wim Leers: Update...
-
phenaproxima →
committed 58237485 on 8.x-2.x authored by
tedbow →
- Status changed to Fixed
almost 2 years ago 4:00pm 13 February 2023 - Issue was unassigned.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This unblocked #3318306: #3318306-16: Define the Package Manager API (package_manager.api.php is outdated) → .
Automatically closed - issue fixed for 2 weeks with no activity.
