$field_definitions declared but not been used at propertyDefinitions() and schema() method

Open on Drupal.org →

Created on 23 January 2023, almost 3 years ago

Updated 24 January 2023, almost 3 years ago

Problem/Motivation

Inside of class "ConditionFieldItem" there are two methods "propertyDefinitions()" and "schema()" that have $field_definitions in the parameter but isn't been used

Proposed resolution

We can just remove the unused code to be clear and organized

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: works as designed

Version

2.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @renatog
@renatog opened merge request.
Status changed to Needs review almost 3 years ago10:14pm 23 January 2023
Comment almost 3 years ago →
renatog
MR crated with the fix: https://git.drupalcode.org/project/condition_field/-/merge_requests/5
Comment almost 3 years ago →
🇭🇺Hungary nagy.balint
Hi!

But it is part of the interface:
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F...
=>
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F...
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F...
Status changed to Closed: works as designed almost 3 years ago7:14pm 24 January 2023
Comment almost 3 years ago →
renatog
Got it. I was looking for interface but I didn't find before.

Closing as Works as designed. Thanks a lot

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024