Webform 6.1.4 breaks drush data export

Indeed, I have checked the changes as well and with some debugging I've found that the removal of an access exclusion was the cause of it. The drush user just didn't have access anymore to the query results.

I have attached a patch which puts that line back. There was probably a reason for the removal but I will let this discussion for the maintainers.

Maybe we only disable access checking via Drush CLI.

Sounds reasonable to me, people with access to drush have other means of accessing this data anyway, no harm done in allowing everyone with CLI access to also be able to export results.

I can confirm this solves the problem for me.

To see whether this only applies to exports, I also tried purging submissions via drush, which worked.

I also exported the complete resultset as CSV via drush, used pm:enable webform_submission_export_import and tried to re-import the exported data.

It failed at importing because it stated mandatory fields were missing (which is wrong, they are part of the exported CSVs).

If I skip the validation with --skip_validation=<first field that needs validation>, the import basically seems to work, apart from errors like
> [error] <myform>: Email not sent for <myhandler> handler because a To, CC, or BCC email was not provided
(which is also wrong, as the export definitely contains the needed fields).
I am unsure what value to pass for --skip_validation[=SKIP_VALIDATION] as a description for the needed value is missing from the usage output (I guess a comma separated list of fields?)

The import ends with

>  [notice] Imported 4 of 4 submissions…
>  [notice] Submission import completed. (total: 4; created: 4; updated: 0; skipped: 0)

However, I don't see any relevant data in the submissions, only 127.0.0.1 as submission IP gets added, but no actual submission data.

There is no data added to table webform_submission_data.

The same happens with 6.1.3 as well, however, so I am not sure whether this is related. I guess this should go in another ticket.

I don't have any setup right now that allows me to test whether other drush commands might be hindered by the (permission changes in the) 6.1.4 update.

Thanks!

Does the patch fix the immediate issue? Can it be committed AS-IS?

As I said,

I can confirm this solves the problem for me.

If that's enough, then yeah.
I just wanted to probably raise awareness that other functionality might also be affected and I may not have covered it fully by my manual test.
I'll open a separate ticket for the other findings.

Automatically closed - issue fixed for 2 weeks with no activity.