- Issue created by @DamienMcKenna
- πΊπΈUnited States DamienMcKenna NH, USA
This comes from changes made in π Add return types on all custom class methods Fixed to add method return types to all custom methods, and some of them have multiple allowed return types, e.g.:
public function label(): TranslatableMarkup|string {
PHP 7.4 does not support this, it only works with PHP 8.0.
This means we have the choice of either fixing it, which would involve some changes to how the methods work, or relaxing the APIs to just say "mixed" instead of listing the specific items, or limiting the v2 modules to PHP 8.0.
- Status changed to Needs review
almost 2 years ago 10:46am 23 January 2023 - πΊπΈUnited States DamienMcKenna NH, USA
This changes the module to require PHP 8.0.
- πΊπΈUnited States DamienMcKenna NH, USA
What I might do is make v2 require PHP 8 and mark it the recommended version, and leave v1 available until D9 support ends in November.
-
DamienMcKenna β
committed 8df5a1b1 on 2.0.x
Issue #3335741 by DamienMcKenna: Indicate the module now requires PHP 8....
-
DamienMcKenna β
committed 8df5a1b1 on 2.0.x
- Status changed to Fixed
almost 2 years ago 6:42pm 23 January 2023 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.