Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 20 January 2023, over 2 years ago
Updated 24 January 2023, over 2 years ago

FILE: /var/www/web/modules/contrib/cas/tests/modules/cas_user_interaction_test/src/CasUserInteractionTestForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/modules/cas_user_interaction_test/src/CasUserInteractionTestSubscriber.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------
32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/modules/cas_test/src/CasTestSubscriber.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
40 | ERROR | Missing parameter comment
43 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Unit/CasPropertyBagTest.php
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
119 | ERROR | [x] Expected 1 blank line after function; 0 found
120 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Unit/Service/CasProxyHelperTest.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
118 | ERROR | The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines
214 | ERROR | The array declaration extends to column 117 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Unit/CasServerConfigTest.php
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
136 | ERROR | [x] Expected 1 blank line after function; 0 found
137 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Functional/CasBulkAddCasUsersTest.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Functional/CasUserFormFieldTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
112 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
216 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Functional/CasEventsTest.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/tests/src/Functional/CasSubscriberTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
132 | ERROR | [ ] The array declaration extends to column 209 (the limit is 80). The array content should be split up over multiple lines
135 | WARNING | [x] '@TODO Test that visting page as a bot does NOT trigger a redirect.' should match the format '@todo Fix problem X here.'
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Form/BulkAddCasUsers.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
126 | ERROR | [ ] Doc comment for parameter $email_hostname does not match actual variable name
150 | ERROR | [ ] The array declaration extends to column 151 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Form/CasSettings.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 23 ERRORS AND 4 WARNINGS AFFECTING 27 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
20 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
219 | ERROR | The array declaration extends to column 444 (the limit is 80). The array content should be split up over multiple lines
406 | WARNING | #options values usually have to run through t() for translation
407 | WARNING | #options values usually have to run through t() for translation
408 | WARNING | #options values usually have to run through t() for translation
537 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
538 | ERROR | The array declaration extends to column 148 (the limit is 80). The array content should be split up over multiple lines
541 | ERROR | The array declaration extends to column 154 (the limit is 80). The array content should be split up over multiple lines
550 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
587 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
594 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
598 | ERROR | The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
599 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
601 | ERROR | The array declaration extends to column 119 (the limit is 80). The array content should be split up over multiple lines
604 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
605 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
607 | ERROR | The array declaration extends to column 113 (the limit is 80). The array content should be split up over multiple lines
608 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
609 | ERROR | The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines
610 | ERROR | The array declaration extends to column 101 (the limit is 80). The array content should be split up over multiple lines
611 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines
612 | ERROR | The array declaration extends to column 129 (the limit is 80). The array content should be split up over multiple lines
613 | ERROR | The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines
617 | ERROR | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
622 | ERROR | The array declaration extends to column 121 (the limit is 80). The array content should be split up over multiple lines
635 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
636 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Controller/ForceLoginController.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
56 | WARNING | [x] 'TODO: What if CAS is not configured? need to handle that case.' should match the format '@todo Fix problem X here.'
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Controller/LogoutController.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
106 | WARNING | [x] 'TODO: Allow cas server config to be altered.' should match the format '@todo Fix problem X here.'
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Controller/ServiceController.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
31 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
252 | ERROR | The array declaration extends to column 115 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Controller/ProxyCallbackController.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
71 | WARNING | [x] '@TODO: Check that request is coming from configured CAS server to avoid' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/CasPropertyBag.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Exception/CasLoginException.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
7 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
43 | ERROR | [x] Expected "\Drupal\Component\Render\MarkupInterface|string" but found "\Drupal\Component\Render\MarkupInterface|string;" for @var tag in member variable comment
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Exception/CasProxyException.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Exception/CasSloException.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Exception/CasValidateException.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
7 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/CasRedirectData.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------
7 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
101 | ERROR | [x] Use null coalesce operator instead of ternary operator.
141 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Event/CasPreLoginEvent.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
122 | ERROR | Each @deprecated tag must have a @see tag immediately following it
126 | ERROR | The trigger_error message 'Using __METHOD__ () is deprecated in cas:8.x-1.7 and is removed from cas:8.x-2.0. Use ::allowLogin() or ::cancelLogin() instead.' does not match the strict
| | standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Event/CasPreValidateServerConfigEvent.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
36 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Service/CasLogout.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Service/CasValidator.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
21 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Service/CasUserManager.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
132 | ERROR | The trigger_error message 'Calling CasUserManager::__construct() without the $cas_proxy_helper argument is deprecated in cas:8.x-1.6 and the $cas_proxy_helper argument will be required
| | in cas:8.x-1.10.' does not match the relaxed standard format: %thing% is deprecated in %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
133 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
156 | ERROR | The trigger_error message 'Calling CasUserManager::register() without the $local_username argument is deprecated in cas:8.x-1.6 and the $local_username argument will be required in
| | cas:8.x-2.0.' does not match the relaxed standard format: %thing% is deprecated in %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Service/CasProxyHelper.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
18 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
88 | WARNING | [x] 'TODO: Consider allowing the config to be altered.' should match the format '@todo Fix problem X here.'
119 | WARNING | [x] 'TODO: Consider allowing the config to be altered.' should match the format '@todo Fix problem X here.'
176 | ERROR | [ ] The array declaration extends to column 135 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Service/CasRedirector.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
19 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/web/modules/contrib/cas/src/Service/CasHelper.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
15 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

Time: 1.98 secs; Memory: 16MB

🐛 Bug report
Status

Closed: won't fix

Version

1.0

Component

CAS

Created by

🇲🇩Moldova sergiu stici

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs review over 2 years ago
  • Issue was unassigned.
  • Status changed to Closed: won't fix over 2 years ago
  • Comment over 2 years ago →
    🇷🇴Romania claudiu.cristea Arad 🇷🇴

    The 8.x-1.x is not supported anymore

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024