Include dependencies in the composer.json with composer require webform

Created on 20 January 2023, almost 2 years ago
Updated 23 January 2023, almost 2 years ago

Problem/Motivation

Currently we have all dependencies in the info file, that works fine but we can also put the dependencies in the composer.json to download handle that dependencies

We saw that some projects that extend the webform also has only in the info file, for example:
Webform Content Creator that is used by 1,600+ sites have the dependency only on this info, but don't have the dependencies in the composer.json

In the other hand the Webform Entity View has that in the info and in the composer.json

Steps to reproduce

Proposed resolution

We can put that in the composer.json with require drupal/webform, and validate if everything will continue working fine

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇧🇷Brazil renatog Campinas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs work almost 2 years ago
  • Status changed to Needs review almost 2 years ago
  • 🇧🇷Brazil renatog Campinas

    @nagy.balint, I tested here in all scenarios and worked fine

    As I'm also a maintainer of some projects I validated scenarios simulating different users:

    1. Existent users, just getting the new composer.json = OK;
    2. New users without webform/commerce previously = OK;
    3. New users with webform/commerce previously = OK;
    4. New users with webform/commerce previously but in difference versions = OK.

    In all cases composer worked as expected. So don't worry that this change is safe to go

    Thank you so much, Nagy

  • Status changed to Fixed almost 2 years ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024