Created on 19 January 2023, over 2 years ago
Updated 2 February 2023, over 2 years ago

Problem/Motivation

FILE: /var/www/html/web/modules/contrib/security_review/README.md
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
85 | WARNING | Line exceeds 80 characters; contains 81 characters
| | (Drupal.Files.TxtFileLineLength.TooLong)
93 | WARNING | Line exceeds 80 characters; contains 274 characters
| | (Drupal.Files.TxtFileLineLength.TooLong)
-------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/js/security_review.run_and_review.js
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
| | (Generic.PHP.UpperCaseConstant.Found)
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/src/CheckResult.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
53 | ERROR | [x] Do not append variable name "$hushed_findings" to the type declaration in a member variable comment
| | (Drupal.Commenting.VariableComment.InlineVariableName)
55 | ERROR | [ ] Class property $hushed_findings should use lowerCamel naming without underscores (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
73 | ERROR | [ ] Type hint "array" missing for $hushed_findings (Drupal.Commenting.FunctionComment.TypeHintMissing)
156 | ERROR | [ ] Public method name "CheckResult::hushed_findings" is not in lowerCamel format (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/src/CheckSettings/FieldSettings.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
21 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
| | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
22 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
| | (DrupalPractice.Objects.GlobalFunction.GlobalFunction)
48 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces (Drupal.Commenting.FunctionComment.ReturnCommentIndentation)
49 | ERROR | [x] Return comment indentation must be 3 spaces, found 1 spaces (Drupal.Commenting.FunctionComment.ReturnCommentIndentation)
60 | WARNING | [ ] Unused variable $position. (DrupalPractice.CodeAnalysis.VariableAnalysis.UnusedVariable)
67 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead (Drupal.Commenting.InlineComment.WrongStyle)
91 | ERROR | [ ] Type hint "array" missing for $values (Drupal.Commenting.FunctionComment.TypeHintMissing)
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/src/Checks/AdminUser.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
8 | WARNING | [x] Unused use statement (Drupal.Classes.UnusedUseStatement.UnusedUse)
57 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use '' quotes instead
| | (Drupal.Semantics.FunctionT.BackslashDoubleQuote)
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/src/Checks/Field.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------
216 | ERROR | [ ] Parameter $additional_info is not described in comment
| | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
219 | ERROR | [ ] Missing parameter comment (Drupal.Commenting.FunctionComment.MissingParamComment)
219 | ERROR | [ ] Missing parameter type (Drupal.Commenting.FunctionComment.MissingParamType)
221 | ERROR | [ ] Description for the @return value is missing (Drupal.Commenting.FunctionComment.MissingReturnComment)
222 | ERROR | [x] Separate the @return and @throws sections by a blank line. (Drupal.Commenting.DocComment.TagGroupSpacing)
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/src/Checks/FilePermissions.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
291 | ERROR | Comment indentation error, expected only 1 spaces
| | (Drupal.Commenting.InlineComment.SpacingBefore)
-----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/src/Checks/VendorDirectory.php
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
| | (Drupal.Classes.UnusedUseStatement.UnusedUse)
8 | WARNING | [x] Unused use statement
| | (Drupal.Classes.UnusedUseStatement.UnusedUse)
9 | WARNING | [x] Unused use statement
| | (Drupal.Classes.UnusedUseStatement.UnusedUse)
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/security_review/tests/modules/security_review_test/security_review_test.info.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | "Description" property is missing in the info.yml file
| | (DrupalPractice.InfoFiles.Description.Missing)
------------------------------------------------------------------------------------------------------------------------

Time: 1.8 secs; Memory: 8MB

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States smustgrave

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024