hook_entity_type_alter function leads to infinite loop

Created on 18 January 2023, almost 2 years ago

Updated 27 February 2024, 10 months ago

I have an implementation of hook_entity_type_alter() that was accessing information from the private tempstore. After a cache clear, this leads to an infinite loop. PrivateTempStore has to get the owner, which leads to AccountProxy loading a User entity, which tries to load the entity type definitions, which runs all the entity_type_alter() functions, which is where we came in.

I don't know how to get around this except "Don't do that." Maybe if the kinds of calls that can lead to this result can be characterized, that could be added to the hook documentation?

🐛 Bug report

Status

Postponed: needs info

Version

11.0 🔥

Component

Entity →

Last updated about 16 hours ago

Maintained by
🇬🇧United Kingdom @catch
🇨🇭Switzerland @berdir
🇩🇪Germany @hchonov

Created by

🇺🇸United States brad.bulger

Live updates comments and jobs are added and updated live.

Needs steps to reproduce

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Postponed: needs info almost 2 years ago7:16pm 19 January 2023
Comment 11 months ago →
🇺🇸United States smustgrave
Should this be reopened?
Comment 10 months ago →
🇬🇧United Kingdom catch
I think it's really a duplicate of #2924075: Plugin discovery hooks and event subscribers can cause infinite loops → .
Comment 10 months ago →
🇺🇸United States brad.bulger
Maybe. That issue seems oriented towards trying to prevent the problem. I am thinking more of how to document it. I am just not sure if there is a way to describe what's happening. Maybe not in 100% of the cases, but would "don't load an entity in this hook" be accurate?

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024