Drupal Coding Standards Issues | phpcs

Created on 18 January 2023, over 1 year ago
Updated 20 January 2023, over 1 year ago

Problem/Motivation

Getting the Following errors/warnings

FILE: .../contrib/fontawesome_menu_icons/js/fontawesome_menu_icons.js
-----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

FILE: .../contrib/fontawesome_menu_icons/fontawesome_menu_icons.install
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------------------------------------------------
13 | WARNING | [ ] Line exceeds 80 characters; contains 109 characters
13 | WARNING | [x] 'TODO: Drupal Rector Notice: Please delete the following comment after you've made any
| | necessary changes.' should match the format '@todo Fix problem X here.'
14 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
21 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
21 | WARNING | [x] 'TODO: Drupal Rector Notice: Please delete the following comment after you've made any
| | necessary changes.' should match the format '@todo Fix problem X here.'
22 | WARNING | [ ] Line exceeds 80 characters; contains 130 characters
25 | WARNING | [x] A comma should follow the last multiline array item. Found: id
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

FILE: .../contrib/fontawesome_menu_icons/fontawesome_menu_icons.module
-----------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------------
50 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
98 | WARNING | [x] There must be no blank line following an inline comment
157 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
205 | WARNING | [x] There must be no blank line following an inline comment
360 | ERROR | [ ] Missing short description in doc comment
361 | ERROR | [ ] Missing parameter comment
361 | ERROR | [ ] Missing parameter type
377 | ERROR | [ ] Missing short description in doc comment
378 | ERROR | [ ] Missing parameter comment
378 | ERROR | [ ] Missing parameter type
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/fontawesome_menu_icons

Proposed resolution

Fix the errors and warnings.

Remaining tasks

Creating The patch

User interface changes

Nothing....

API changes

Nothing....

Data model changes

Nothing.....

🐛 Bug report
Status

Closed: cannot reproduce

Version

2.0

Component

Code

Created by

🇮🇳India Prem Suthar gujrat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Closed: cannot reproduce over 1 year ago
Production build 0.69.0 2024