Fix head tests for webform_localization

Created on 17 January 2023, over 1 year ago

Problem/Motivation

head tests are failing, could be due to a change upstream, disable failing tests (for now)

I don't like disabling failing tests but in this case it seems like the webform module changed in some way that we do not have control over. It's for a disabled textfield and it's less likely that we'd ever want to translate a disabled text field than one that is not disabled.

I'm going to be open to putting this back in if someone complains or finds some more information about this to explain it.

Steps to reproduce

see automated test results here:
https://www.drupal.org/pift-ci-job/2569479 β†’

4	1	Webform Localization.WebformLocalizationStringSubmissionTestCase
βœ“		-setUp
βœ“		-addLanguage
βœ“		-setTranslationOptions
βœ“		-createWebformTranslation
βœ—	
webformSubmissionExecute
fail: [Webform] Line 155 of sites/all/modules/webform_localization/tests/webform_localization.submission.test:
Component textfield_disabled data integrity check when using sample values.

fail: [Webform] Line 157 of sites/all/modules/webform_localization/tests/webform_localization.submission.test:
Expected Array
(
    [0] => bar
)


Received Array
(
    [0] => 
)


fail: [Webform] Line 155 of sites/all/modules/webform_localization/tests/webform_localization.submission.test:
Component textfield_disabled data integrity check when using sample values.

fail: [Webform] Line 157 of sites/all/modules/webform_localization/tests/webform_localization.submission.test:
Expected Array
(
    [0] => bar
)


Received Array
(
    [0] => 
)

Proposed resolution

Disable affected test

Remaining tasks

Disable the failing test on disabled text fields

User interface changes

N/A

API changes

N/A

Data model changes

N/A

πŸ› Bug report
Status

Active

Version

4.0

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada joseph.olstad

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.69.0 2024