Unsupported operand types: int - string in advagg_bundler

Created on 16 January 2023, almost 2 years ago

Updated 14 July 2023, over 1 year ago

Problem/Motivation

Fatal error happens on any page with PHP 8.1.

Steps to reproduce

Install Core 7.94 on MariaDB and PHP 8.1.12, with advagg 7.x-2.x dev.

Observe

Fatal error: Uncaught TypeError: Unsupported operand types: int - string in (path)/sites/all/modules/contrib/advagg/advagg_bundler/advagg_bundler.module:143

The error appears to have been introduced by spurious ">" being added to the max(...) calls in #2323691: Rename bundler "advagg_auto_bundler", create "advagg_manual_bundler" → in 2014.

Proposed resolution

Remove the ">" from the max() calls.

Remaining tasks

Validate.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Closed: duplicate

Version

2.0

Component

Bundler

Created by

🇫🇷France fgm Paris, France

Live updates comments and jobs are added and updated live.

PHP 8.1
The issue particularly affects sites running on PHP version 8.1.0 or later.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs review almost 2 years ago5:46pm 16 January 2023
Status changed to RTBC almost 2 years ago1:38am 18 January 2023
Comment over 1 year ago →
🇺🇸United States hargobind Austin, Texas
This is a duplicate of 🐛 db condition and join causes fatal errors in PHP 8 Fixed , but attribution should be given for the work done.
Status changed to Closed: duplicate over 1 year ago4:23pm 14 July 2023
Comment over 1 year ago →
🇸🇰Slovakia poker10
Thanks. I will commit the older issue (and transfer credits).

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024