Add config for a correspondent ckeditor5-stylesheets configuration in Vartheme BS4

Created on 16 January 2023, almost 2 years ago
Updated 22 January 2023, almost 2 years ago

Problem/Motivation

Having the following warning when site admin switch to use CKEditor 5

Warning message
The Vartheme (Bootstrap 4 - SASS), Bootstrap Barrio and Vartheme Claro themes have ckeditor_stylesheets configured, but without corresponding ckeditor5-stylesheets configurations. See the change record for details.

https://www.drupal.org/node/3259165
#3194084: Support functionality equivalent to ckeditor_stylesheets

Proposed resolution

Have the following as a starter logic in the vartheme_bs4.info.yml file and VARTHEME_BS4_SUBTHEME.starterkit.yml starter kit for .info.yml file

ckeditor_stylesheets:
  # Base
  - css/base/bootstrap.base.css
  - css/base/bootstrap5-utilities.base.css
  - css/base/vartheme_bs4.base.css
  # Components
  - css/components/ajax.component.css
  - css/components/alerts.component.css
  - css/components/autocomplete.component.css
  - css/components/bs-callouts.component.css
  - css/components/contextual.component.css
  - css/components/details.component.css
  - css/components/feed-icon.component.css
  - css/components/field.component.css
  - css/components/file.component.css
  - css/components/header.component.css
  - css/components/help.component.css
  - css/components/icons.component.css
  - css/components/image-button.component.css
  - css/components/item-list.component.css
  - css/components/list-group.component.css
  - css/components/navbar.component.css
  - css/components/node.component.css
  - css/components/page.component.css
  - css/components/progress-bar.component.css
  - css/components/shortcut.component.css
  - css/components/sidebar.component.css
  - css/components/site-footer.component.css
  - css/components/skip-link.component.css
  - css/components/table.component.css
  - css/components/tabledrag.component.css
  - css/components/tableselect.component.css
  - css/components/tablesort.component.css
  - css/components/tablesort-indicator.component.css
  - css/components/textarea.component.css
  - css/components/ui-dialog.component.css
  - css/components/ui-widget.component.css
  - css/components/user.component.css
  - css/components/varicons.component.css
  - css/components/vb-tags.component.css
  - css/components/views.component.css
  - fonts/fontawesome-free/css/all.min.css
  # Layout
  - css/layout/edge2edge.layout.css
  - css/layout/equal-height.layout.css
  # Theme
  - css/theme/content.theme.css

ckeditor5-stylesheets:
  # Base
  - css/base/bootstrap.base.css
  - css/base/bootstrap5-utilities.base.css
  - css/base/vartheme_bs4.base.css
  # Components
  - css/components/ajax.component.css
  - css/components/alerts.component.css
  - css/components/autocomplete.component.css
  - css/components/bs-callouts.component.css
  - css/components/contextual.component.css
  - css/components/details.component.css
  - css/components/feed-icon.component.css
  - css/components/field.component.css
  - css/components/file.component.css
  - css/components/header.component.css
  - css/components/help.component.css
  - css/components/icons.component.css
  - css/components/image-button.component.css
  - css/components/item-list.component.css
  - css/components/list-group.component.css
  - css/components/navbar.component.css
  - css/components/node.component.css
  - css/components/page.component.css
  - css/components/progress-bar.component.css
  - css/components/shortcut.component.css
  - css/components/sidebar.component.css
  - css/components/site-footer.component.css
  - css/components/skip-link.component.css
  - css/components/table.component.css
  - css/components/tabledrag.component.css
  - css/components/tableselect.component.css
  - css/components/tablesort.component.css
  - css/components/tablesort-indicator.component.css
  - css/components/textarea.component.css
  - css/components/ui-dialog.component.css
  - css/components/ui-widget.component.css
  - css/components/user.component.css
  - css/components/varicons.component.css
  - css/components/vb-tags.component.css
  - css/components/views.component.css
  - fonts/fontawesome-free/css/all.min.css
  # Layout
  - css/layout/edge2edge.layout.css
  - css/layout/equal-height.layout.css
  # Theme
  - css/theme/content.theme.css

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.11 , vartheme_bs4-9.0.20

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3333820 : Added config for a correspondent ckeditor5-stylesheets configuration in Vartheme BS4
📌 Task
Status

Fixed

Version

9.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024