[Regression] Taxonomy term page missing HTML links canonical and shortlink when using views

Open on Drupal.org →

Created on 15 January 2023, almost 2 years ago

Updated 26 January 2023, almost 2 years ago

Problem/Motivation

When viewing a term page like /taxonomy/term/1, or its alias, the rendered page is missing the links rel="canonical" and rel="shortlink". This is a regression starting at 9.3.0.

This only applies when the view taxonomy_term is enabled, but that means site builders need to pick between having a term page that lists content OR having a term page with canonical links (and therefore better SEO).

Background

In #2922570: The node view page triggers a lot of expensive access checks for relationship links → the addition of these links was moved from taxonomy_page_attachments_alter() to the EntityViewController. Since the taxonomy_term view takes over the canonical route and bypasses the term view controller, the links are never added.

Steps to reproduce

Install Drupal (standard install profile)
Create a term in the existing "Tags" vocabulary
View the term page and see that there AREN'T canonical or shortlink links
Disable the "Taxonomy term (Content)" view
View the term page and see that there ARE canonical and shortlink links

Proposed resolution

Revert the removal of taxonomy_page_attachments_alter().

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated 7 minutes ago

Maintained by
🇺🇸United States @xjm
🇬🇧United Kingdom @catch

Created by

🇺🇸United States rocketeerbkw Austin, Tx

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs review almost 2 years ago1:20am 16 January 2023
Status changed to RTBC almost 2 years ago8:41am 17 January 2023
Comment almost 2 years ago →
System Message
The last submitted patch, 5: 3333608-5-fail.patch, failed testing. View results →
Comment almost 2 years ago →
System Message
The last submitted patch, 5: 3333608-5-fail.patch, failed testing. View results →
Comment almost 2 years ago →
System Message
The last submitted patch, 5: 3333608-5-fail.patch, failed testing. View results →
Comment almost 2 years ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
I wonder if we should be seeking a generic fix in views when it takes over the canonical route for an entity. Wouldn't the same thing happen if we used views to take over the canonical route for nodes?
Status changed to Needs work almost 2 years ago12:04pm 26 January 2023
Comment almost 2 years ago →
System Message
The last submitted patch, 5: 3333608-5.patch, failed testing. View results →

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024