[PP-1] Consider deprecating heading_id property from pagination templates

Created on 13 January 2023, almost 2 years ago
Updated 20 November 2023, 12 months ago

Postponed until πŸ› Pager h4 causes accessibility flag on many pages Fixed lands
Postponed until πŸ› Stable9 accessibility update: Pager h4 causes accessibility flag on many pages RTBC lands

Problem/Motivation

In πŸ› Pager h4 causes accessibility flag on many pages Fixed and πŸ› Stable9 accessibility update: Pager h4 causes accessibility flag on many pages RTBC , the header_id property is no longer needed in templates as it was solely used for pagers to reference an element containing their label text, and that label text has since moved to aria-label which eliminates the need for such an id.

It is possible that contrib/custom themes are using + expecting header_id, so we'd need to deprecate it in Drupal 10 then remove it in Drupal 11.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Closed: won't fix

Version

11.0 πŸ”₯

Component
MarkupΒ  β†’

Last updated 16 days ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Add Stable9 issue since it is also a dependency.
    General core issue has been merged.
    Stable9 issue is RTBC.

  • πŸ‡¬πŸ‡§United Kingdom andrewmacpherson

    This issue is already postponed, but the reason for postponement has changed.

    This issue was filed as a follow-up to πŸ› Pager h4 causes accessibility flag on many pages Fixed .

    Since then, I've made a very strong objection to removing the heading from the pagination template. In which case, the heading ID is still needed.

    That would make this issue would a wont-fix. I'll leave it in a postponed state while the other is still being discussed.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    I agree this is won't fix even if we make the heading configurable since we would still need the heading_id.

    I'll still leave this open until those are resolved.

  • Status changed to Closed: won't fix 12 months ago
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    The solution bypasses the need for this so I'll close this.

Production build 0.71.5 2024