Contrib.social

Incorrect plugin id check breaks plugins

Open on Drupal.org →
Created on 12 January 2023, almost 2 years ago
Updated 31 August 2023, over 1 year ago

Problem/Motivation

The plugin ID check implemented in #3125484: Do not allow invalid plugin ID on tfa.validation.setup form → breaks (custom) plugins, because it re-introduces the implicit requirement of a setup plugin id that ends with "_setup" that was removed in 2020 in #2925066: Refactor implicitly named setup plugin id expectations to an annotation property → .

Steps to reproduce

Update the TFA module on a site that has a setup plugin that does not have an id that ends with "_setup".

Proposed resolution

Do not check the plugin ID by checking if its setup plugin ID ends with "_setup", but actually check if the setup plugin is a TFA (setup) plugin instead.

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇱Netherlands Marty2081

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024