CSS coding standards

Created on 11 January 2023, about 2 years ago
Updated 16 November 2023, over 1 year ago

Problem/Motivation

This module is running CSSLint and we get a few CSS coding standards reported.

Steps to reproduce

The output can be seen in the regular tests on https://www.drupal.org/pift-ci-job/2564331 β†’
There are four css files with a total of 11 errors:

css/module_filter.css
5	Element (input.form-search) is overqualified, just use .form-search without element name.
15	Negative text-indent doesn't work well with RTL. If you use text-indent for image replacement explicitly set direction for that item to ltr.

css/module_filter.modules.css
1	Don't use IDs in selectors.
2	Don't use IDs in selectors.

css/module_filter.modules_tabs.css
109	Element (input.table-filter-text) is overqualified, just use .table-filter-text without element name.
115	Element (col.checkbox) is overqualified, just use .checkbox without element name.
118	Element (col.name) is overqualified, just use .name without element name.
121	Element (col.version) is overqualified, just use .version without element name.
124	Element (col.links) is overqualified, just use .links without element name.

css/module_filter.update_status.css
1	Don't use IDs in selectors.
5	Don't use IDs in selectors.

Proposed resolution

  1. Do not run CSSLINT [done]
  2. Re-evaluate when #2866840: Use stylelint as opposed to csslint in DrupalCI β†’ is finished
πŸ“Œ Task
Status

Fixed

Version

4.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom jonathan1055

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs review about 2 years ago
  • Status changed to Fixed about 2 years ago
  • Status changed to Postponed about 2 years ago
  • Status changed to Fixed over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Moving back to Fix, addressing any stylelint in the gitlab ticket now.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024