Compatible with D10

Created on 10 January 2023, over 1 year ago
Updated 18 August 2023, 10 months ago

Quick fix, see attached patch.

πŸ“Œ Task
Status

RTBC

Version

2.1

Component

Code

Created by

πŸ‡¨πŸ‡³China Lugir

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • D10 also requires Drush 11
    I was hoping to use this module on our site, but it is already on PHP8 and Drush 11, so it is not compatible.

  • πŸ‡¨πŸ‡¦Canada TrevorBradley

    Just stumbled across this. I just created this same patch independently. This solution is correct - core_version_requirement, drupal/core, AND drush/drush need to be upgraded.

    @scambler, you've got a tiny error in your patch: "drush/drush": "^10.0" || ^11.0 isn't valid. Let's try this new patch.

  • πŸ‡¨πŸ‡¦Canada TrevorBradley

    Derp - I've got multiple patches in my patch. Once more with feeling...

  • πŸ‡¨πŸ‡¦Canada TrevorBradley

    Additionally - upgrade_status did a reactor test against the code - apart from the core/drush updates, there's no deprecated code. This should be a fairly straightforward upgrade.

  • Status changed to RTBC about 1 year ago
  • πŸ‡¨πŸ‡¦Canada TrevorBradley

    Derp. My patch still has that errant code in it. One last time...

    On the positive side - I just tested this on my D10 site, by moving the patched code into modules/custom - works great in D10.

  • First commit to issue fork.
  • πŸ‡ΊπŸ‡¦Ukraine kolesnikoff

    You can install the patched D10-compatible version of the module using this configuration of the composer.json file:

    {
        "require": {
            "drupal/views_autocomplete_api": "2.1.x"
        },
        "repositories": [
            {
                "type": "composer",
                "url": "https://packages.drupal.org/8",
                "exclude": [
                    "drupal/views_autocomplete_api"
                ]
            },
            {
                "type": "git",
                "url": "https://git.drupalcode.org/issue/views_autocomplete_api-3332131"
            }
        ],
    }
    
Production build 0.69.0 2024