- šµšPhilippines clarkssquared
Hi @Jay
I applied your MR !2 but I can still see these PHPCS issues
ā node_paypal_payment git:(8.x-1.x) curl https://git.drupalcode.org/project/node_paypal_payment/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 443 0 443 0 0 796 0 --:--:-- --:--:-- --:--:-- 808 patching file 'src/Form/NPPConfigForm.php' ā node_paypal_payment git:(8.x-1.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml node_paypal_payment FILE: ...local/web/modules/contrib/node_paypal_payment/node_paypal_payment.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | "core_version_requirement" property is missing in the info.yml | | file -------------------------------------------------------------------------------- FILE: ...l_local/web/modules/contrib/node_paypal_payment/node_paypal_payment.module -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Component\Utility\Crypt. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ..._local/web/modules/contrib/node_paypal_payment/src/Form/NPPPaymentForm.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Form\FormBase. 44 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead 113 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ocal/web/modules/contrib/node_paypal_payment/src/Controller/NPPPayment.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 48 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead 67 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead 109 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead 129 | WARNING | \Drupal calls should be avoided in classes, use dependency | | injection instead -------------------------------------------------------------------------------- FILE: ...cal/web/modules/contrib/node_paypal_payment/src/Controller/NPPRedirect.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Controller\ControllerBase. 20 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead 31 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead 55 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency | | injection instead -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 252ms; Memory: 10MB ā contrib git:(main) ā