Hello. We just encountered this issue in beta6. In grepping for use of tippy in webforms I noticed some inconsistent versioning.
composer.libraries.json: "url": "https://registry.npmjs.org/tippy.js/-/tippy.js-6.3.7.tgz",
src/WebformLibrariesManager.php: 'download_url' => Url::fromUri('https://registry.npmjs.org/tippy.js/-/tippy.js-6.3.7.tgz'),
webform.libraries.yml: /libraries/tippyjs/dist/: https://unpkg.com/tippy.js@6.2.6/dist/(also, popper.js seems to not have been downloaded and is being fetched remotely from unpkg directly in the browser, causing occasional browser blocks - not sure if that is related. investigating both.)
- Status changed to Needs review
over 1 year ago 2:31pm 5 September 2023 - last update
over 1 year ago 534 pass - πΊπΈUnited States jrockowitz Brooklyn, NY
@Kyber thank you for catching that mistake which needs to be fixed. I am not sure this will fix other related tippyjs problems.
I was hoping it'd also fix this issue I'm still having, but I guess not.
π Entity Select issues and PHP warning Closed: cannot reproduce
Note, this site was not using composer, but I see you do your own JS fetches anyway so I don't see why it should matter.
I'll doublecheck what's going on with tippy and popper.
Worst case, I just specify the correct paths, manually fetch, or add a ludwig config.-
jrockowitz β
authored 522dc2ef on 6.2.x
Issue #3331649 by jrockowitz: Libraries.yml looks in wrong folder for...
-
jrockowitz β
authored 522dc2ef on 6.2.x
- Status changed to Fixed
over 1 year ago 12:00pm 7 September 2023 - π¨π¦Canada namscott
I manually applied the patch and still had to go in and change /dist/ to /6.x/ and add the .min did I miss something?
Automatically closed - issue fixed for 2 weeks with no activity.