Drupal coding standard issues

Created on 6 January 2023, almost 2 years ago

Updated 9 February 2023, almost 2 years ago

Problem/Motivation

$ phpcs --standard=drupal entity_share_cron

FILE: ...p1\htdocs\drupal9\d9.3\web\modules\entity_share_cron\css\settings_form.css
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...\drupal9\d9.3\web\modules\entity_share_cron\src\EntityShareCronService.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...d9.3\web\modules\entity_share_cron\src\EntityShareCronServiceInterface.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...tdocs\drupal9\d9.3\web\modules\entity_share_cron\src\Form\SettingsForm.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
110 | ERROR | [x] Use null coalesce operator instead of ternary operator.
155 | ERROR | [x] Use null coalesce operator instead of ternary operator.
168 | ERROR | [x] Use null coalesce operator instead of ternary operator.
192 | ERROR | [x] Use null coalesce operator instead of ternary operator.
197 | ERROR | [x] Use null coalesce operator instead of ternary operator.
217 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...al9\d9.3\web\modules\entity_share_cron\src\HookHandler\CronHookHandler.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
113 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...odules\entity_share_cron\src\Plugin\QueueWorker\EntityShareCronPending.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...s\entity_share_cron\tests\src\Functional\EntityShareCronFunctionalTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 1.92 secs; Memory: 10MB

📌 Task

Status

Fixed

Version

3.0

Component

Code

Created by

🇮🇳India Jitendra_Kumar

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Assigned to Grimreaper
Comment almost 2 years ago →
🇫🇷France Grimreaper France 🇫🇷
I don't know where warnings like

ERROR | [x] End of line character is invalid; expected "\n" but found | | "\r\n"
are coming from.

Rest of the MR is OK.
Comment almost 2 years ago →
System Message

Grimreaper → committed 88dc239c on 3.0.x authored by Jitendra_Kumar →
Issue #3331504 by Jitendra_Kumar: Drupal coding standard issues
Issue was unassigned.
Status changed to Fixed almost 2 years ago10:27am 9 February 2023
Comment almost 2 years ago →
🇫🇷France Grimreaper France 🇫🇷
Test fails because entity_share is not up-to-date.

Merged.
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024