Created on 5 January 2023, about 2 years ago
Updated 20 August 2024, 5 months ago

PHPCS reported the following errors:

FILE: /Users/soliman-harkas/projects/multibasebox/projects/pattern/src/PatternTwigFunction.php
----------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------
  3 | ERROR | [x] There must be one blank line after the namespace declaration
 16 | ERROR | [x] Expected 1 blank line after function; 2 found
 26 | ERROR | [x] Expected 1 blank line after function; 2 found
 35 | ERROR | [x] Parameter comment must end with a full stop
 36 | ERROR | [x] Expected 1 spaces after parameter type; 2 found
 38 | ERROR | [x] Separate the @param and @return sections by a blank line.
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
šŸ“Œ Task
Status

Needs work

Component

Code

Created by

šŸ‡©šŸ‡ŖGermany solimanharkas Hamburg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @solimanharkas,

    I applied MR!1, it was applied smoothly and fixed most of the phpcs issues.

    These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

    āžœ  pattern git:(1.0.x) curl https://git.drupalcode.org/project/pattern/-/merge_requests/1.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100   901    0   901    0     0   2496      0 --:--:-- --:--:-- --:--:--  2495
    patching file src/PatternTwigFunction.php
    āžœ  pattern git:(1.0.x) āœ— ..
    āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pattern
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/pattern.module
    ---------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
    ---------------------------------------------------------------------------------------------------------------------------------------------------
     18 | ERROR   | [x] Short array syntax must be used to define arrays
     28 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "pattern" but expected "pattern_pattern"
     36 | WARNING | [x] A comma should follow the last multiline array item. Found: )
    ---------------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/README.md
    --------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------------------
      3 | WARNING | Line exceeds 80 characters; contains 266 characters
     28 | WARNING | Line exceeds 80 characters; contains 189 characters
    --------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/modules/test_pattern/test_pattern.module
    ---------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ---------------------------------------------------------------------------------------------------------------------
     19 | ERROR | [x] Empty array declaration must have no space between the parentheses
    ---------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ---------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/modules/test_pattern/test_pattern.info.yml
    -----------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------
     8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
    -----------------------------------------------------------------------------------------------------------------------
    
    Time: 98ms; Memory: 10MB
    
    āžœ  contrib

    Thank you.

Production build 0.71.5 2024