- šµšPhilippines cleavinjosh
Hi @solimanharkas,
I applied MR!1, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
:ā pattern git:(1.0.x) curl https://git.drupalcode.org/project/pattern/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 901 0 901 0 0 2496 0 --:--:-- --:--:-- --:--:-- 2495 patching file src/PatternTwigFunction.php ā pattern git:(1.0.x) ā .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml pattern FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/pattern.module --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------------------- 18 | ERROR | [x] Short array syntax must be used to define arrays 28 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "pattern" but expected "pattern_pattern" 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ) --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/README.md -------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 266 characters 28 | WARNING | Line exceeds 80 characters; contains 189 characters -------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/modules/test_pattern/test_pattern.module --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Empty array declaration must have no space between the parentheses --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/pattern/modules/test_pattern/test_pattern.info.yml ----------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" ----------------------------------------------------------------------------------------------------------------------- Time: 98ms; Memory: 10MB ā contrib
Thank you.