- Status changed to Closed: won't fix
5 months ago 8:35am 17 January 2024 - 🇫🇷France DuaelFr Montpellier, France
PHP Coding Standards do not apply on JS files. We have specific coding standards for JavaScript → and we use ESLint to check them.
Getting following error/warnings
FILE: /app/modules/contrib/editor_file/js/plugins/drupalfile/plugin.js
----------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
----------------------------------------------------------------------
16 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "NULL" but found "null"
40 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
56 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
178 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "NULL" but found "null"
182 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "NULL" but found "null"
221 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
227 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "NULL" but found "null"
----------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 644ms; Memory: 12MB
Run following command
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/editor_file
Run phpcbf --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/editor_file
Closed: won't fix
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
PHP Coding Standards do not apply on JS files. We have specific coding standards for JavaScript → and we use ESLint to check them.