- 🇩🇰Denmark ressa Copenhagen
The MR actually adds a well-formatted README.md file, with useful information:
https://git.drupalcode.org/issue/acquia_purge-3331035/-/tree/3331035-upd...The current README.txt is empty:
https://git.drupalcode.org/project/acquia_purge - 🇺🇸United States japerry KVUO
No, it doesn't. Its a script that is actually inaccurate. INSTALL.md has the install steps, PROJECTPAGE.md has the general readme. This PR doesn't offer anything of substance, and actually suggests a required module that not only isn't required, but is recommended to disable:
// The purge_queuer_url can quickly cause issues. if ($this->moduleHandler->moduleExists('purge_queuer_url')) { $this->recommendation = $this->t("For an optimal experience, you're recommended to not use the URLs queuer (and module) as this module creates a very high load. If you keep using it, make sure your website has only a small number of content so that the risks of using it, are contained."); return self::SEVERITY_WARNING; }
While there are some formatting and content changes needed (like removing the Drupal 7 part, and maybe renaming PROJECTPAGE to README.md, these will be done as part of the next release process (similar to phpcs linting)
- 🇩🇰Denmark ressa Copenhagen
My bad, I should have checked. In that case you were right to reject it.