Contrib.social

CKEditor 5 / Drupal 10 compatibility: filter implies this text format is not HTML anymore

Open on Drupal.org →
Created on 4 January 2023, over 1 year ago

Problem/Motivation

During the process of upgrading to Drupal 9.5 and Ckeditor 5 with the accordion we are getting the following error:

CKEditor 5 only works with HTML-based text formats. The "CKEditor Accordion" (filter_ckeditor_accordion) filter implies this text format is not HTML anymore.

I've found another module that had the same issue, see:
https://www.drupal.org/project/improve_line_breaks_filter/issues/3326729 →

Currently the filter states the following :

type = Drupal\filter\Plugin\FilterInterface::TYPE_MARKUP_LANGUAGE

Steps to reproduce

Proposed resolution

We would probably have to change the type to one of the following:

  • FilterInterface::TYPE_HTML_RESTRICTOR: HTML tag and attribute restricting filters.
  • FilterInterface::TYPE_MARKUP_LANGUAGE: Non-HTML markup language filters that generate HTML.
  • FilterInterface::TYPE_TRANSFORM_IRREVERSIBLE: Irreversible transformation filters.
  • FilterInterface::TYPE_TRANSFORM_REVERSIBLE: Reversible transformation filters.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇳🇱Netherlands Arantxio Dordrecht

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 8 months ago →
    🇺🇸United States emptyvoid

    Experiencing this error on a fresh code base installed using Composer on Drupal 10.1.5
    Loading a Drupal 9 database snapshot and then issuing drush updatedb.

    Update hangs:

    ------------------ ------------- ------------- ------------------------------- 
  Module             Update ID     Type          Description                    
 ------------------ ------------- ------------- ------------------------------- 
  editor             image_lazy_   post-update   Enable filter_image_lazy_load  
                     load                        if editor_file_reference is    

    [notice] Update started: editor_post_update_image_lazy_load
>  [error]  The "filter_ckeditor_accordion" plugin does not exist. Valid plugin IDs for Drupal\filter\FilterPluginManager are: editor_file_reference, entity_embed, filter_autop, filter_url, filter_image_lazy_load, filter_html, filter_align, filter_html_image_secure, filter_htmlcorrector, filter_null, filter_caption, filter_html_escape, media_embed, views_embed 
>  [error]  Update failed: editor_post_update_image_lazy_load 
 [error]  Update aborted by: editor_post_update_image_lazy_load

    Drupal 10.1.5
    Ckeditor 5
    ckeditor_accordion 2.0.3

    Won't allow for update in place and no upgrade path.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024