Contrib.social

Add a custom library for toolbar secondary moderation sidebar tab items

Open on Drupal.org →
Created on 3 January 2023, almost 2 years ago
Updated 30 May 2023, over 1 year ago

Problem/Motivation

Having a visual regression issue of toolbar tabs and tab items.

Steps to reproduce

Given that the Moderation Sidebar was enabled with the workflow on a selected content type
When navigating to the node page with moderation workflow
Then the toolbar tab and tab item will conflict with the style
And wrong border radios
And no spacing between

Proposed resolution

1. Have the custom library with fixes and integration between the Gin Toolbar secondary and the Moderation Sidebar components.

toolbar-secondary-moderation-sidebar:
  css:
    component:
      css/components/toolbar-secondary-moderation-sidebar.component.css: { }

2. Extend the moderation sidebar library to add the custom vartheme_claro/toolbar-secondary-moderation-sidebar integration.

libraries-extend:
  moderation_sidebar/main:
    - vartheme_claro/toolbar-secondary-moderation-sidebar

3. 📌 Add a library info alter to the Varbase Admin. To alter the moderation sidebar main library with dependency on Vartheme Claro toolbar secondary moderation sidebar integration Fixed

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 → , vartheme_claro-4.0.0-alpha1 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3330814 → : Added a custom library for toolbar secondary moderation sidebar tab items
📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024