Declare upgrade status from D7

Created on 28 December 2022, over 1 year ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

As of 2022-12-27 / flood_control-2.2.4 (likely since #3251881: Migrate settings from D7 to D8|9 β†’ ), I can confirm that this module properly migrates my Flood Control settings from Drupal 7 to Drupal 9. Thank you very much for your hard work to make this easy for me!

But as of Drupal core 8.8.x, modules can declare their Drupal 8 (or 9) upgrade status ( changelog β†’ , issue #2936365: Migrate UI - allow modules to declare the state of their migrations β†’ ). Failing to do so makes it seem as if this module has no migrations and/or is not ready to be upgraded... for example, see the following image...

... this could be a barrier preventing other people from upgrading their sites to Drupal 8/9/10+.

Steps to reproduce

  1. Set up a Drupal 7 site. Download and install flood_control-7.x-1.0, and change some settings.
  2. Set up a Drupal 9 site with the Standard install profile. Download and install flood_control-2.2.4. Enable core's migrate, migrate_drupal, and migrate_drupal_ui modules.
  3. As an administrator, visit /upgrade to begin the Drupal-to-Drupal migration. Proceed through the wizard to the "What will be upgraded?" step.
    • Expected behaviour: "Flood control" is in the "Modules that will be upgraded" section.
    • Actual behaviour: "Flood control" is in the "Modules that will not be upgraded" section.
  4. Click "Perform upgrade" and wait for the upgrade to finish.
  5. Check the Flood control settings at /admin/config/people/flood-control - note the custom settings were migrated from D7 so the migration is working.

Proposed resolution

Declare the finished upgrade path from D7 by creating a migrations/state/flood_control.migrate_drupal.yml and populating it appropriately.

Remaining tasks

  1. Release

User interface changes

None.

API changes

None.

Data model changes

None.

✨ Feature request
Status

Fixed

Version

2.2

Component

Code

Created by

πŸ‡¨πŸ‡¦Canada mparker17 UTC-4

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024