phpcs stopped working since the switch to testing on Drupal 10.0.x by default

Given that this is such a nightmare to debug, I figured … why not switch to GitLab CI?

So I first wanted to give it a try on a simpler project … and I succeeded: #3334243-18: [PP-1] CDN 4.x requires PHP >=8.1 but composer does not respect it due to bug in d.o composer facade → 😄

I know we chose not to go this route in 🌱 Determine if we should use GitLab CI Closed: duplicate , but … maybe we can use it just for phpcs? 🤞

Hm … based on https://git.drupalcode.org/help/ci/pipelines/merge_request_pipelines.md#..., it seems that I'm unable to trigger Pipelines, but @tedbow has been triggering them (probably unknowingly) for a long time: https://git.drupalcode.org/project/automatic_updates/-/pipelines.

So this is caused by #3324540: PHPCS fails on Drupal 10 & 9 → , which means a global phpcs is being run if the --drupalci flag is passed. But we've only been patching the logic for running phpcs on the list of changed files. So we were still patching the logic that no longer was being run! 😅

Rather than testing only the changed files, testing all files with phpcs always is actually good, especially because it's plenty fast for this project anyway. But then in order to do that rather than scanning the entirety of Drupal core instead of just our project needs one small tweak.

@tedbow please merge 3328742-wim and close all other merge requests. If I try to close them, I get a 404…

FYI, output for the "DONE!" commit:

FILE: ...ontrib/automatic_updates/src/AutomaticUpdatesServiceProvider.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 15 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
    |       |     (Drupal.Classes.ClassDeclaration.BraceOnNewLine)
 22 | ERROR | [x] There should be no white space after an opening
    |       |     "("
    |       |     (Drupal.WhiteSpace.OpenBracketSpacing.OpeningWhitespace)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 605ms; Memory: 4MB

— https://www.drupal.org/pift-ci-job/2580901 →

👆 proves that phpcs is once again working 👍

tedbow → closed merge request !679

tedbow → closed merge request !631

tedbow → closed merge request !634

tedbow → closed merge request !643

A promised only for core-mvp, critical issues

Thanks @Wim Leers 🙏

Automatically closed - issue fixed for 2 weeks with no activity.