- Status changed to Needs review
over 1 year ago 2:46pm 23 June 2023 - Status changed to Fixed
over 1 year ago 2:51pm 23 June 2023 - πΏπ¦South Africa rawdreeg
I reckon a simpler way to handle would be to update the access when unblocking.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
10 months ago 2:13am 8 January 2024 - π¦πΊAustralia richard.thomas
Was this issue intended to be set to fixed, I can't see any associated code changes?
The previous patch no longer applies to 2.4, attached a re-rolled one.
- Status changed to Needs review
10 months ago 7:41am 8 January 2024 - πΏπ¦South Africa rawdreeg
Hi Richard,
This was marked closed due to inactivity.
I looked at your patch, and I reckon a simpler way to handle it would be to update the access when unblocking. Alternatively, can you create a merge request, and I will review your proposed changes?
Thanks,
- Merge request !25Update last access time when unblocking users to prevent re-blocking on next cron run. β (Merged) created by richard.thomas
- π¦πΊAustralia richard.thomas
No worries, happy to try the simpler alternative. I've added an issue fork with a hook to update the access time when a user is unblocked and added some extra testing to verify the logic.
Thanks
- Status changed to RTBC
10 months ago 1:22pm 11 January 2024 - Status changed to Fixed
10 months ago 1:33pm 11 January 2024 - πΏπ¦South Africa rawdreeg
Thanks for your contribution, Richard. This has been released in 2.5
- Status changed to Fixed
10 months ago 6:13am 16 January 2024