- @jrockowitz opened merge request.
- Status changed to Needs review
almost 2 years ago 8:44pm 1 February 2023 - Status changed to Needs work
almost 2 years ago 2:32am 7 February 2023 - π§π·Brazil renatog Campinas
Works well but the code
// Add new 'Download PDF' submission action. $config = \Drupal::configFactory()->getEditable('webform.settings'); $actions = $config->get('settings.webform_submission_bulk_form_actions') ?: []; $actions[] = 'webform_submission_print_download_action'; $config->set('settings.webform_submission_bulk_form_actions', $actions) ->save();
can be isolated in a function, since it's being used in two places
- Status changed to Needs review
almost 2 years ago 2:35am 7 February 2023 - π§π·Brazil renatog Campinas
Done, MR updated with this: https://git.drupalcode.org/project/webform/-/merge_requests/284
Now there is
modules/webform_entity_print/includes/webform_entity_print.install.inc
with the function_webform_entity_print_update_add_new_download_pdf_submission_action()
that has this responsibility. This function is being called in both places and reducing to avoid duplicated code - π§π·Brazil renatog Campinas
Done, MR updated with this: https://git.drupalcode.org/project/webform/-/merge_requests/284
Now there is
modules/webform_entity_print/includes/webform_entity_print.install.inc
with the function_webform_entity_print_update_add_new_download_pdf_submission_action()
that has this responsibility. This function is being called in both places and reducing to avoid duplicated code -
bgilhome β
authored 3fed1a32 on 6.2.x
Issue #3328205 by jrockowitz, RenatoG, bgilhome: Add print download bulk...
-
bgilhome β
authored 3fed1a32 on 6.2.x
-
bgilhome β
authored 51c6679a on 6.2.x
Issue #3328205 by jrockowitz, RenatoG, bgilhome: Add print download bulk...
-
bgilhome β
authored 51c6679a on 6.2.x
- Status changed to Fixed
almost 2 years ago 6:53pm 14 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.