Add more elements validation according to DHL constraints

Created on 16 December 2022, over 1 year ago
Updated 21 March 2023, over 1 year ago

Following this issue β†’ , we need more elements validation.
Also, as discussed with @solene_ggd, reworking the address lines validation by simply adding the #maxlength attribute would be cleaner and avoid the multiple error messages issue πŸ› Duplicate error messages with inline_form_errors Needs work .

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡«πŸ‡·France NicolasGraph Strasbourg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡«πŸ‡·France solene_ggd

    Changed the patch fixing warning when the field doesn't have a maxlength :

    Warning : Undefined array key "#maxlength" in _commerce_dhl_express_field_maxlength_alter()

  • πŸ‡«πŸ‡·France solene_ggd

    Changed the patch fixing error when a field doesn't exist in the address field. The error was :

    TypeError: _commerce_dhl_express_field_maxlength_alter(): Argument #1 ($field) must be of type array, null given, called in /home/maetvade/web/art/web/modules/contrib/commerce_dhl_express/commerce_dhl_express.module on line 123

  • Status changed to Fixed over 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024