Redirects to external URLs are not allowed by default. When adding or updating blocks

Created on 11 December 2022, almost 2 years ago

Updated 15 June 2023, over 1 year ago

Problem/Motivation

Facing the following error message on saving a block

Redirects to external URLs are not allowed by default, use \Drupal\Core\Routing\TrustedRedirectResponse for it.

Steps to reproduce

Given that the "Layout Builder iFrame Modal" was enabled
And the "Add block (layout_builder.add_block)" checkbox was checked in the "Layout Builder Iframe Modal settings"
When I add a block to a section the following message shows up in Modal Window

User error: Redirects to external URLs are not allowed by default, use \Drupal\Core\Routing\TrustedRedirectResponse for it. in Drupal\Core\EventSubscriber\RedirectResponseSubscriber->checkRedirectUrl() (line 84 of core/lib/Drupal/Core/EventSubscriber/RedirectResponseSubscriber.php).
Drupal\Core\EventSubscriber\RedirectResponseSubscriber->checkRedirectUrl(Object, 'kernel.response', Object)
call_user_func(Array, Object, 'kernel.response', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.response') (Line: 202)
Symfony\Component\HttpKernel\HttpKernel->filterResponse(Object, Object, 1) (Line: 255)
Symfony\Component\HttpKernel\HttpKernel->handleThrowable(Object, Object, 1) (Line: 92)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 67)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Proposed resolution

Have a management for the Redirect Response Subscriber on internal redirects not external URLs
Deactivate the the internal redirect event if it was not needed

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Closed: outdated

Version

1.2

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇳India rohitrajputsahab Uttam Nagar, Delhi
Use this patch
Status changed to Needs review over 1 year ago5:45am 28 February 2023
Comment over 1 year ago →
🇮🇳India rohitrajputsahab Uttam Nagar, Delhi
Status changed to RTBC over 1 year ago11:09am 20 March 2023
Comment over 1 year ago →
🇫🇷France vbouchet
I tried the patch and it works. Important to note that layout_builder_iframe_modal_link_alter() is using a isModalRoute($link_route_name) in 1.3.0 instead of the hardcoded rule that was here in 1.2.0 so it is a pure 1:1 mapping btw 1.3.0 fix and this patch.
Status changed to Closed: outdated over 1 year ago6:37pm 15 June 2023
Comment over 1 year ago →
🇺🇸United States bkosborne New Jersey, USA
There's nothing to review here, the fix was already included in 1.3.0 it seems.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024