- Status changed to Fixed
over 1 year ago 8:49pm 30 March 2023 - heddn Nicaragua
Looks like this was fixed. Marking as such. If I've closed in error, please re-open.
Automatically closed - issue fixed for 2 weeks with no activity.
As a follow-up to
#3291431: Incomplete config schema and wrong file name for settings →
, I think the old crowdin.setting should be deleted in an update. IIUC the old behavior was that the same configuration was saved both to crowdin.settings and tmgmt.translator.crowdin, which would imply it's safe just to delete crowdin.settings. However it's not impossible a developer has directly updated crowdin.settings... which would've worked up until 1.4. With hindsight I guess the ideal solution would've been to copy the values from crowdin.settings to tmgmt.translator.crowdin and do the delete as part of the 1.4 release. I don't think it's right to copy the values over now because someone might have upgraded to 1.4 and made a change to their config, only affecting tmgmt.translator.crowdin.
crowdin.settings still exists.
Create a post update to check if crowdin.settings exists. If so:
tmgmt.translator.crowdin then err on the side of caution by not deleting the legacy config (to avoid possible data loss) and just give a message directing the developer to verify the current config and delete the legacy config manually;
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Looks like this was fixed. Marking as such. If I've closed in error, please re-open.
Automatically closed - issue fixed for 2 weeks with no activity.