Contrib.social

Add css libraries for page component and fix its story

Open on Drupal.org →
Created on 6 December 2022, about 2 years ago
Updated 30 May 2023, over 1 year ago

Problem/Motivation

There are no CSS libraries loaded for the Page component.

Proposed resolution

  • Create 2 SCSS files for the Page component (LTR and RTL) and place them alongside the page.twig component.
  • Add these files to webpack to make webpack compile them to CSS files.
  • Add 2 libraries in vartheme_bs5.libraries.yml for page (LTR and RTL) assets.
  • Attach these 2 libraries on page.twig file by the language direction variable.
  • Change CSS page component story to the new CSS file path.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 → , vartheme_bs5-2.0.0-alpha4

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3325484 → : Added css libraries for page component and fix its story
📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇯🇴Jordan Abdullah Yassin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024