Contrib.social

Bug when an item is first updated then ignored during a single page request

Open on Drupal.org →
Created on 4 December 2022, almost 2 years ago
Updated 7 May 2024, 4 months ago

The scenario is a bit complicated and does (I think) require custom code, but I’d say this should still work well in the Search API – and currently doesn’t. Steps to reproduce:

  1. Create an index with “Index items immediately” enabled.
  2. Use a custom datasource that ignores some items/entities based on their properties. E.g., this could be a datasource that only tracks published items.
  3. Perform some action that, in a single page request, will track an item first as updated, and then as deleted, by the datasource.
  4. (For testing purposes, you can also replace the previous two steps by manually calling first Index::trackItemsUpdated() and then Index::trackItemsDeleted() on the same item(s).)
  5. The expected result here would, of course, be that the item is missing from both the tracking table and the server.
  6. Actually, however, it will only be missing from the tracking table, but still be on the server. The reason for this is that the delete from the server happens immediately when tracking it, while the indexing operation is only queued when the update is tracked and happens via PostRequestIndexing, at the end of the page request. Therefore, the update “overwrites” the delete.

As said, the setup is quite complicated, and probably rare, but I still think this qualifies as a bug in the Search API: when you track the deletion of an item, you wouldn’t expect it to be indexed afterwards.

As a side note, the reason this cannot happen with our own Content Entity datasource (as far as I can see) is that this only discards items based on their type or language. Since the type is immutable and the language is part of the ID (and not really a regular property at all, I’d say), the scenario described here cannot happen. (Except when changing the datasource settings and updating an item twice, all in the same page request.)

🐛 Bug report
Status

Fixed

Version

1.0

Component

Framework

Created by

🇦🇹Austria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024