- @_pratik_ opened merge request.
- 🇮🇳India _pratik_ Banglore
Hi @jurgenhaas,
Created MR for patch #3. and missed occurence.
It cover 1 and 3 from #5.
For point 2, update command will works, right ?
Thanks. - 🇩🇪Germany jurgenhaas Gottmadingen
Thanks a lot @_pratik_ for the MR and the enhancements. There is only one little comment in the code that needs your attention.
As for the update of existing models, unfortunately the existing update command doesn't cover that. The update command recognizes changed in the config forms for the plugins, but the changed token name is being used in config values. So, what's required is an update_hook which goes through all the models, check all the config fields if a token with
[current-form
is being used and replace that with[current_form
. In the eca.install file there are already a few hooks which do similar thing. Using one of them as a blue print should help a lot. - 🇮🇳India _pratik_ Banglore
Hi @jurgenhaas,
I am little occupied with some other priority work. Unable to focus here.
I thought to inform, to not keep you waiting.Thanks.
- Status changed to Needs review
almost 2 years ago 4:19pm 31 January 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
I've resolved the one code issue and added the update hook which updates existing models. For that reason, we need to back port this fix into 1.1.x and 1.0.x so that those models don't be missed out from this update.
- Status changed to RTBC
almost 2 years ago 1:18pm 1 February 2023 - 🇩🇪Germany danielspeicher Steisslingen
Thank you guys for the work.
Good idea to us an update method. This keeps the code clean.
-
jurgenhaas →
committed 96cd808f on 1.2.x authored by
_pratik_ →
Issue #3325190 by _pratik_, jurgenhaas: Make token names consistent
-
jurgenhaas →
committed 96cd808f on 1.2.x authored by
_pratik_ →
-
jurgenhaas →
committed 54c5a9d7 on 1.0.x authored by
_pratik_ →
Issue #3325190 by _pratik_, jurgenhaas: Make token names consistent
-
jurgenhaas →
committed 54c5a9d7 on 1.0.x authored by
_pratik_ →
-
jurgenhaas →
committed b23e0902 on 1.1.x authored by
_pratik_ →
Issue #3325190 by _pratik_, jurgenhaas: Make token names consistent
-
jurgenhaas →
committed b23e0902 on 1.1.x authored by
_pratik_ →
- Status changed to Fixed
almost 2 years ago 1:40pm 1 February 2023 - 🇩🇪Germany jurgenhaas Gottmadingen
Thank you. Merged this into all 3 branches.
- 🇩🇪Germany mxh Offenburg
Why backport? This issue is a task, not a bug fix. Futhermore, despite of having the update hook, there is a risk of breaking compatibility. Therefore, this should've only committed into the current feature branch (1.2.x).
Automatically closed - issue fixed for 2 weeks with no activity.