Remove Components and UI Patterns modules from Varbase Core as they will be managed by the Varbase Components

Created on 4 December 2022, almost 2 years ago
Updated 30 May 2023, over 1 year ago

Problem/Motivation

Varbase Core has a list of modules to make Vartheme BS5 work fine:

  1. Components
  2. UI Patterns
  3. UI Patterns Settings

And now these modules and handled by Varbase Components module.

It's better to move all these modules from Varbase Core to Varbase Components.

Proposed resolution

  • Only remove the Components and UI Patterns modules. Better not to use Varbase Core module to call other Varbase Components
  • Let Varbase profile manage enabling the module on install with the List of default varbase components, which they will be installed when we install varbase.

    https://git.drupalcode.org/project/varbase/-/blob/10.0.x/configbit/defau...
    # ==============================================================================
    # List of default varbase components, which they will be installed
    # when we install varbase.
    # ==============================================================================
    config_bit:
      type: list
      for: varbase.info.yml
      when:
        install_default_components: true
        list:
          dependencies:
            # Enable listed Varbase modules in order at this installation step.
            - varbase_core
            - varbase_components
            - varbase_media
            - varbase_editor
            - varbase_admin
            - varbase_email
            - varbase_security
            - varbase_seo
            - varbase_webform
            - varbase_workflow
            - varbase_page
            - varbase_layout_builder
            - vlplb
            - varbase_total_control
            - varbase_default_content
            - varbase_tour
            - varbase_update_helper
    
  • Add Varbase Components module to Varbase profile and enable it after varbase_core. not Varbase Core

Maybe Varbase Layout Builder module needs to require it too

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 , varbase_core-10.0.0-alpha1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3325179 : Removed Components and UI Patterns modules from Varbase Core as they will be managed by the Varbase Components
📌 Task
Status

Fixed

Version

10.0

Component

Code

Created by

🇯🇴Jordan Abdullah Yassin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024