TestSettingSummariesContentType has a few problems

Created on 2 December 2022, about 2 years ago
Updated 22 January 2023, almost 2 years ago

Problem/Motivation

The \Drupal\Tests\node\FunctionalJavascript\TestSettingSummariesContentType class has a few problems:
1. It's wrongly named so the test is not actually run - this was noted over in #2296635-58: Evaluate performance impact of limiting test discovery to *Test.php filename suffix β†’ but that issue is trying to do way more.
2. It's slow because it has strpos('Not published', $summary) !== FALSE; in a wait an the arguments to strpos are the wrong way around...

Proposed resolution

Rename the test so it runs and fix the wait so that it is quick and will fail if it does not meet it's expectations.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

N/a

πŸ› Bug report
Status

Fixed

Version

9.5

Component
Node systemΒ  β†’

Last updated 4 days ago

No maintainer
Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024