Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string in PHP 8.1

That strlen thing seems unecessary? array_filter() defaults to an empty check, that should be sufficient here?

Hi @Berdir,

I reviewed this, strlen function is needed here, array_filter() does not do an empty check.

Following is the example code.

<?php
$a1=array('a','b','c','');
print_r(array_filter($a1, function ($item) {
        return $item !== NULL && strlen($item);
}));

// Output: With strlen 
Array ( [0] => a [1] => b [2] => c )

// Output: Without strlen 
Array ( [0] => a [1] => b [2] => c [3] => ) 

https://3v4l.org/naCiZ says otherwise :)

Hi @Berdir,

Thanks for your suggestion, I have updated the code, here is the Patch

keshav.k → made their first commit to this issue’s fork.

Hi @Berdir,
I have updated the MR with latest changes. Please check.

Merged.

I can confirm, the error no longer exists.
I only have problems with the synchronization of the address data.
ADDRESS:
addr1: [webform_submission:values:address:address]
addr2: [webform_submission:values:address:address_2]
city: [webform_submission:values:address:city]
state: [webform_submission:values:address:state_province]
zip: [webform_submission:values:address:postal_code]
country: [webform_submission:values:address:country]
does not work anymore.
Thanks anyway.

Automatically closed - issue fixed for 2 weeks with no activity.