CSSDeprecationAnalyzer::getAllCSSFiles() returns directories with a name that ends in ".css"

I've faced the same issue and written a quick test for this.

Attaching both test only (which should fail) and test + prudloff's fix patches (which should pass tests and probably should be fine to merge).

Updated patches to run with PHP 7.3.

Ah wow, makes a ton of sense.

Hmm that's interesting, the new CSSDeprecationAnalyzerTest test class haven't been picked up by CI.
Any ideas? Feels like I missed something totally simple.

Another one round of me fighting with CI.

The last submitted patch, 8: 3324201-8-test-only.patch, failed testing. View results →

The last submitted patch, 8: 3324201-8-test-and-fix.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

You won this time, CI, but it's not over!
The test have failed due to the way I've used tempnam for creating a temporary directory.

Thank you CI, you were a worthy opponent, our battle have been legendary.

Ready for review.

Looks good to me, thanks for the elaborate test coverage!

Automatically closed - issue fixed for 2 weeks with no activity.