- πΊπΈUnited States coderdan
Adding a patch which builds on asherry's solution to include tests.
Regarding refactoring (ie: comment #7). While I agree a refactor is in order here, it is my opinion that this would be somewhat dangerous to do given the existing lack of test coverage. I would propose working on tests first before refactoring takes place.
- Status changed to Needs review
almost 2 years ago 5:48pm 28 February 2023 -
mandclu β
committed eb232d55 on 3.7.x
Issue #3324142 by coderdan, asherry: Unknown or bad timezone, when...
-
mandclu β
committed eb232d55 on 3.7.x
-
mandclu β
committed eb232d55 on 4.0.x
Issue #3324142 by coderdan, asherry: Unknown or bad timezone, when...
-
mandclu β
committed eb232d55 on 4.0.x
- Status changed to Fixed
almost 2 years ago 6:56pm 2 March 2023 - π¨π¦Canada mandclu
Thanks for everyone's work on this. I was able to reproduce the problem and validate that the patch fixed it. Merged in and will roll a new release shortly.
I am also open to the idea of refactoring the code. While the 4.0.x branch is still in alpha would be a great time to work on that, if anyone wants to take a stab at it.
Automatically closed - issue fixed for 2 weeks with no activity.