- 🇪🇸Spain facine
@jsacksick there are cross-dependencies that make it impossible not to install product.
The idea is to be able to use a custom purchasable entity and an add-to-cart different from the one provided by core.
The alternative would be to create an alternative cart contrib without these dependencies.
Do you think it would be possible to introduce these changes or would you prefer to create a contrib module?
- last update
over 1 year ago 699 pass, 42 fail - Status changed to Needs work
over 1 year ago 12:03pm 30 August 2023 - 🇮🇱Israel jsacksick
I'm not sure why you're setting this task to "needs review"... As far as I can see, the patch submitted has 42 failing tests in case you haven't noticed.
- last update
over 1 year ago 779 pass, 4 fail - last update
over 1 year ago 781 pass, 2 fail - last update
over 1 year ago 786 pass - last update
over 1 year ago 784 pass, 2 fail - Status changed to Needs review
over 1 year ago 9:24am 31 August 2023 - 🇪🇸Spain facine
@jsacksick, I've fixed the tests, the errors in D10 are not related to these changes: https://www.drupal.org/pift-ci-job/2746156 → .
"3.0.x-dev test with PHP 8.1 & MySQL 5.7, Drupal 10.1.x" is failing since "2 Jan 2023 at 16:32 CET"
- Merge request !345Issue #3323623 by facine, jsacksick: Remove Commerce Product dependency from... → (Merged) created by jsacksick
-
jsacksick →
committed 228d8573 on 3.0.x
Issue #3323623 by facine, jsacksick: Remove Commerce Product dependency...
-
jsacksick →
committed 228d8573 on 3.0.x
- 🇮🇱Israel jsacksick
@facine: Thank you! For some reason when applying the patch, the config files weren't properly moved to the optional directory.
Had to spend time fixing other test failures to make sure this didn't introduce a regression, but tests are green! Good job :). Automatically closed - issue fixed for 2 weeks with no activity.