Remove Commerce Product dependency from Commerce Cart and Commerce Checkout

Created on 24 November 2022, about 2 years ago
Updated 30 August 2023, over 1 year ago

Describe your bug or feature request.

Since we can sell any Purchasable Entity using Commerce Core, I think the cart should not require Commerce Product and add its functionalities that require Commerce Product only if the module is active.

Feature request
Status

Needs review

Version

2.0

Component

Developer experience

Created by

🇪🇸Spain facine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇪🇸Spain facine

    @jsacksick there are cross-dependencies that make it impossible not to install product.

    The idea is to be able to use a custom purchasable entity and an add-to-cart different from the one provided by core.

    The alternative would be to create an alternative cart contrib without these dependencies.

    Do you think it would be possible to introduce these changes or would you prefer to create a contrib module?

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update over 1 year ago
    699 pass, 42 fail
  • Status changed to Needs work over 1 year ago
  • 🇮🇱Israel jsacksick

    I'm not sure why you're setting this task to "needs review"... As far as I can see, the patch submitted has 42 failing tests in case you haven't noticed.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    779 pass, 4 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update over 1 year ago
    781 pass, 2 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update over 1 year ago
    786 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    784 pass, 2 fail
  • Status changed to Needs review over 1 year ago
  • 🇪🇸Spain facine

    @jsacksick, I've fixed the tests, the errors in D10 are not related to these changes: https://www.drupal.org/pift-ci-job/2746156 .

    "3.0.x-dev test with PHP 8.1 & MySQL 5.7, Drupal 10.1.x" is failing since "2 Jan 2023 at 16:32 CET"

  • Pipeline finished with Canceled
    2 months ago
    Total: 307s
    #304987
  • Pipeline finished with Success
    2 months ago
    Total: 561s
    #304995
  • Pipeline finished with Success
    2 months ago
    Total: 523s
    #305017
    • jsacksick committed 228d8573 on 3.0.x
      Issue #3323623 by facine, jsacksick: Remove Commerce Product dependency...
  • Pipeline finished with Skipped
    2 months ago
    #305116
  • 🇮🇱Israel jsacksick

    @facine: Thank you! For some reason when applying the patch, the config files weren't properly moved to the optional directory.
    Had to spend time fixing other test failures to make sure this didn't introduce a regression, but tests are green! Good job :).

  • Pipeline finished with Success
    2 months ago
    Total: 1054s
    #305100
  • Pipeline finished with Failed
    2 months ago
    #311721
  • Pipeline finished with Canceled
    2 months ago
    Total: 113s
    #311733
  • Pipeline finished with Failed
    2 months ago
    Total: 574s
    #311734
  • Pipeline finished with Canceled
    2 months ago
    Total: 194s
    #311748
  • Pipeline finished with Success
    2 months ago
    Total: 596s
    #311750
  • Pipeline finished with Success
    2 months ago
    Total: 562s
    #311904
  • Pipeline finished with Success
    2 months ago
    Total: 450s
    #311915
  • Pipeline finished with Failed
    2 months ago
    Total: 546s
    #313811
  • Pipeline finished with Canceled
    2 months ago
    Total: 414s
    #313916
  • Pipeline finished with Success
    2 months ago
    Total: 472s
    #313926
  • Pipeline finished with Success
    2 months ago
    Total: 967s
    #313957
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    5 days ago
    Total: 214s
    #370950
  • Pipeline finished with Success
    1 day ago
    Total: 1034s
    #375408
  • Pipeline finished with Canceled
    1 day ago
    Total: 68s
    #375418
Production build 0.71.5 2024