Contrib.social

Change Varbase Video Player behavior on clicking on videos with cover images. Supporting Drimage changes for locally hosted and remote videos

Open on Drupal.org →
Created on 15 November 2022, almost 2 years ago
Updated 29 May 2023, over 1 year ago

Problem/Motivation

Proposed resolution

Switch selectors on the js-video-player-icon class for:

  • Locally Hosted Video
            if (
          $(this)
            .closest(".media")
            .find(".varbase-video-player > video")
            .length > 0
        ) {
          $(this)
            .closest(".media")
            .find(".varbase-video-player > video")
            .get(0)
            .play();
        }
  • Remote Youtube Video
            if (
          $(this)
            .closest(".media")
            .find('.varbase-video-player > iframe[src*="youtube.com"]')
            .length > 0
        ) {
          const closestYoutubeIframe = $(this)
            .closest(".media")
            .find('.varbase-video-player > iframe[src*="youtube.com"]')
            .get(0).contentWindow;
          closestYoutubeIframe.postMessage("play", "*");
        }
  • Remote Vimeo Video
            if (
          $(this)
            .closest(".media")
            .find('.varbase-video-player > iframe[src*="vimeo.com"]'
            ).length > 0
        ) {
          const closestVimeoIframe = $(this)
            .closest(".media")
            .find('.varbase-video-player > iframe[src*="vimeo.com"]')
            .get(0).contentWindow;
          closestVimeoIframe.postMessage("play", "*");
        }

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1 → , varbase_media-10.0.0-alpha1 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3321536 → : Changed Varbase Video Player behavior on clicking on videos with cover images. Supporting Drimage changes for locally hosted and remote videos
📌 Task
Status

Fixed

Version

10.0

Component

Code

Created by

🇯🇴Jordan Rajab Natshah Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024