Replace README.txt with README.md

The patch works fine and moving it to RTBC.

Thanks to Jay and Kavitha. Maintainers are pressed for time now but we will get to this shortly. My only question is what version(s) this should go in.

Welcome aboard. We could use more testing on the Drupal 10 release too.

Had time to look thru the patch and am moving it back to needs work.

There are several references to "http:" instead of "https:" in the patch. Lines 4 and 14. These should be changed to https:

The maintainers at lines 56 and lines 57 should be changed to the current active maintainers:
Luke.Leber https://www.drupal.org/u/lukeleber →
and
Frank Kelly https://www.drupal.org/u/fkelly12054gmail.com →

Just a quick note. I took at look at readme.txt in 4.0... version. Whatever is done in 8.x needs to be done in 4.x ... Not sure if separate patches are needed but we should make these versions consistent.

Also, I'm not sure if we should keep the last couple of lines in the patch listing maintainers. Maintainers can change over time. We don't want to have to be re-patching the patch, I don't think. Even determining who is an "active" maintainer can be a bit subjective. I'm not sure if there is a standard for readme files on this. Unless there is I'd suggest just leaving it out.

Hello Everyone !!
Created a patch for juicebox 8.x-3.x-dev. addressed#12.
Can someone please review the patch.

Thank you for your support!!!

Our Senior Maintainer, Luke Leber, is the person who got the tests to pass after they had been failing for 2+ years. I'm not sure that the 8.x-3.x release has all (or any) of the changes needed to make the tests pass. Luke also modified the Drupal ci.yml file to accommodate Juicebox requirements to have a Javascript library loaded.

When he gets a chance he can enlighten us on this. I'm not sure tests are really required for a patch such as this.

I'm also not sure how "far back" we want to go in patching older versions of Juicebox. 8.x-3.0-alpha is identical to 8.x-3-x dev and should be used if you are "stuck" on Drupal 8 or 9 for the time being. 4.0.0-alpha1 is for sites migrating to Drupal 10 (but also should work for 8 or 9). It works with 9.3 and Drupal 10.

I would prioritize patching the 4.0 series and getting to a stable release that support 9.3+ and all releases of Drupal 10.

Moving it to RTBC as the patch works fine.

Sorry. Subject to being overruled by our senior maintainer, I am marking this as "closed, won't fix".

Due mainly to time constraints and several years of technical debt piled up by there being no active maintainership on the Juicebox project for more than 2 years, we have our hands full getting a full set of patches working for a stable version of Juicebox for Drupal 10. Diverting attention to fixing Juicebox for Drupal 8 or Drupal 9 versions is not what we are aiming for. The Drupal 8 version 8.x-3.0-alpha2 has been working just fine functionally for 2+ years. Changing a readme file won't change or "improve" that.

We will try to get the readme file improvements in to the stable version of Juicebox for Drupal 10 we release, once we deal with all pending functional issues: such as, just for instance, that JuiceboxFormatter.php patches that fix a dependency injection issue also cause the program to not work.

kavitha@specbee.com is owed no thanks for the "reviews" posted here.

Before an issue can be marked RTBC the changes need to be reviewed, this wasn't done.

kavitha@specbee.com needs to read up on Issue Etiquette → . Pay attention on #11 and #14 on the "Don't" list.

The "reviews" posted here by kavitha@specbee.com are spam.

Thanks @Gisle. Your support is much appreciated.